Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap GCM endpoints with FCM #126

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Swap GCM endpoints with FCM #126

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c984e
Swap GCM endpoints with FCM
jholloway7 Apr 9, 2019
bdb4e5f
Fix trailing slash
jholloway7 Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcm/gcm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from urllib.parse import unquote


GCM_URL = 'https://gcm-http.googleapis.com/gcm/send'
GCM_URL = 'https://fcm.googleapis.com/fcm/send/'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the trailing slash. It won't work with the slash

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it wasn't tested because I replaced the library in my stack. I was just trying to be helpful to the maintainer. I updated the pull request to remove the trailing slash, but doesn't look like it will be merged any time soon regardless.



class KeyAuth(requests.auth.AuthBase):
Expand Down