Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use custom types #160

Merged
merged 2 commits into from
Jan 22, 2024
Merged

refactor: use custom types #160

merged 2 commits into from
Jan 22, 2024

Conversation

12rambau
Copy link
Member

Fix #128

take advantage of this to make mypy happy and reintroduce it into the pipelines

@12rambau 12rambau changed the title Types refactor: use custom types Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (ff54bf9) 0.00% compared to head (e6c455e) 0.00%.

Files Patch % Lines
geetools/User/__init__.py 0.00% 19 Missing ⚠️
geetools/Image/__init__.py 0.00% 13 Missing ⚠️
geetools/types.py 0.00% 13 Missing ⚠️
geetools/List/__init__.py 0.00% 8 Missing ⚠️
geetools/ComputedObject/__init__.py 0.00% 5 Missing ⚠️
geetools/Dictionary/__init__.py 0.00% 3 Missing ⚠️
geetools/String/__init__.py 0.00% 3 Missing ⚠️
geetools/Date/__init__.py 0.00% 2 Missing ⚠️
geetools/DateRange/__init__.py 0.00% 2 Missing ⚠️
geetools/FeatureCollection/__init__.py 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #160   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         52      53    +1     
  Lines       2919    2938   +19     
=====================================
- Misses      2919    2938   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@12rambau 12rambau merged commit 86097ba into main Jan 22, 2024
9 of 10 checks passed
@12rambau 12rambau deleted the types branch January 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid Union in type descritpions
1 participant