Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-builder): switch to new wasm32v1-none target #4407

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

feat(wasm-builder): switch to new wasm32v1-none target #4407

wants to merge 69 commits into from

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Dec 18, 2024 •
edited
Loading

Resolves #4235 by switching to new wasm32v1-none target (for runtime and smart-contracts).

  • requires Rust 1.84 (will be stable on January 9, 2025).
  • -C target-feature=+sign-ext also works for core and alloc without -Zbuild-std and rust-src component.
  • -C linker-plugin-lto still doesn't work and we can't remove panic locations.

Output WASM files are now in different location ./target/<target>/<profile>/demo_vec.wasm:

- <target> = wasm32-unknown-unknown
+ <target> = gear-wasm

@StackOverflowExcept1on
chore: bump rust version to latest nightly
1d541b3
@StackOverflowExcept1on
fix tests
5a16b0f
@StackOverflowExcept1on
switch to wasm32v1-none target
b290d72
@StackOverflowExcept1on
temporarily switch to beta rust instead of stable
d7ba5ea
@StackOverflowExcept1on
fix anyhow features in utils/node-wrapper
f083676
@StackOverflowExcept1on
Merge remote-tracking branch 'origin/master' into av/rust
ee4490b
@StackOverflowExcept1on
remove TODOs
0d73df0
@StackOverflowExcept1on
fix static_mut_refs warning with gcore::{static_mut, static_ref} macros
c450f77
@StackOverflowExcept1on
fix wait_state_machine test
83004c8
@StackOverflowExcept1on
fix semver in utils/crates-io
0af7df8
@StackOverflowExcept1on
switch to rust 2024 edition
c05cf17
@StackOverflowExcept1on
fix fmt
f39eb7b
@StackOverflowExcept1on
Merge remote-tracking branch 'origin/master' into av/rust
76004be
@StackOverflowExcept1on
link_section -> unsafe(link_section)
ebe30af
@StackOverflowExcept1on
2021 -> 2024
0e51b62
@StackOverflowExcept1on
update cagro_metadata and cargo_toml
d67b957
@StackOverflowExcept1on
fix gear-wasm-builder
b54e2d5
@StackOverflowExcept1on
idk how to fix it rn
8e39e90
@StackOverflowExcept1on
beta -> nightly-2024-12-14 (temp)
3559052
@StackOverflowExcept1on
temp ignore doc tests
733c263
@StackOverflowExcept1on
fix test in gmeta
01d5a97
@StackOverflowExcept1on
Revert "2021 -> 2024"
d3d4ddb 
This reverts commit 0e51b62.
@StackOverflowExcept1on
switch back to 2021 edition and rollback fmt
e2157e8
@StackOverflowExcept1on
revert gtest and gmeta fixes
f08d3ca
@StackOverflowExcept1on
Revert "beta -> nightly-2024-12-14 (temp)"
88d28b4 
This reverts commit 3559052.
@StackOverflowExcept1on
Revert "temporarily switch to beta rust instead of stable"
e1f02b7 
This reverts commit d7ba5ea.
@StackOverflowExcept1on
back to wasm32-unknown-unknown target, set rust-version to 1.82
34b5f0f
@StackOverflowExcept1on
missed this
e771d97
@StackOverflowExcept1on
use match *self instead of &mut Self::Pattern
2bf4edf
@StackOverflowExcept1on
bump to nightly-2024-12-17
52d9fa3
Base automatically changed from av/rust to master January 11, 2025 23:16
breathx
breathx approved these changes Jan 13, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@breathx breathx added A5-dontmerge PR should not be merged yet and removed A0-pleasereview PR is ready to be reviewed by the team labels Jan 13, 2025
ark0f
ark0f requested changes Jan 13, 2025
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
breathx
breathx requested changes Jan 17, 2025
View reviewed changes
utils/wasm-builder/src/wasm_project.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ark0f ark0f Awaiting requested review from ark0f

@breathx breathx Awaiting requested review from breathx

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A5-dontmerge PR should not be merged yet D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-builder uses hacks to build WASMs
3 participants
@StackOverflowExcept1on @ark0f @breathx