feat: Initial multivalue WASM proposal support
#4379
Conversation
ark0f
added
A0-pleasereview
ark0f
requested review from
ByteNacked,
breathx,
StackOverflowExcept1on and
playX18
ark0f
force-pushed
the
al/wasm-multi-value
branch
from
19b9fcd to
7724179
Compare
ark0f
force-pushed
the
al/wasm-multi-value
branch
from
0008c76 to
2284259
Compare
| @@ -592,9 +592,10 @@ debug = true | |||
| [patch.crates-io] | |||
| # sp-io = { version = "38.0.0", git = "https://github.com/gear-tech/polkadot-sdk.git", branch = "gear-polkadot-stable2409" } | |||
| # sp-application-crypto = { version = "38.0.0", git = "https://github.com/gear-tech/polkadot-sdk.git", branch = "gear-polkadot-stable2409" } | |||
|
|
|||
| # these patched dependecies force their `sign_ext` feature to be used by Substrate dependencies | |||
There was a problem hiding this comment.
Are these patches necessary? Substrate (runtime) does not use sign-ext: https://github.com/paritytech/polkadot-sdk/blob/906fa9e51306635245a22e03160d1c761fae6cc3/substrate/utils/wasm-builder/src/wasm_project.rs#L850. Same goes for outdated version wasmi 0.13.2 in our Cargo.lock.
| @@ -17,6 +17,10 @@ gwasm-instrument = { workspace = true, features = ["sign_ext"] } | |||
| derive_more.workspace = true | |||
| enum-iterator.workspace = true | |||
|
|
|||
| # TODO: remove when tooling is updated | |||
There was a problem hiding this comment.
Before updating tooling, it makes sense to replace parity-wasm with gear-wasm in all our crates (except wasmi 0.13.2 and other substrate-related dependencies).
Also try applying existing patches to our tooling as git dependency:
There was a problem hiding this comment.
It should also be under [target.'cfg(force_wasmer_cranelift_i_know_what_i_do)'.dependencies].
|
One more note: the |
No description provided.