Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gtest): removed use of read_state_bytes_using_wasm #4320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(gtest): removed use of read_state_bytes_using_wasm #4320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32d1d54
Removed use of read_state_bytes_using_wasm everywhere except rpc and …
Lazark0x Oct 30, 2024
457c4ff
post-review: additionally removed *_using_wasm functions from gclient…
Lazark0x Nov 5, 2024
bc23a66
Merge branch 'master' into laz/remove-usage-of-read-state-with-wasm
Lazark0x Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 0 additions & 196 deletions examples/new-meta/tests/read_state.rs
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions gclient/src/api/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,8 @@ impl GearApi {
.await
}

/// Same as [`read_state_bytes_using_wasm`](Self::read_state_bytes_using_wasm), but reads the program's state at the block identified by its hash.
/// Same as [`read_state_bytes_using_wasm`](Self::read_state_bytes_using_wasm),
/// but reads the program's state at the block identified by its hash.
pub async fn read_state_bytes_using_wasm_at(
&self,
program_id: ProgramId,
Expand Down Expand Up @@ -353,7 +354,8 @@ impl GearApi {
.await
}

/// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path), but reads the program's state at the block identified by its hash.
/// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path),
/// but reads the program's state at the block identified by its hash.
pub async fn read_state_bytes_using_wasm_by_path_at(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gclient is not rpc or runtime api (it's client that call them), so as we agreed, rpc hole itself won't be removed atm, but each new user space libs shouldn't be able to call it, so feel free to remove it from here as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, additionally removed *_using_wasm functions from gclient and gsdk

&self,
program_id: ProgramId,
Expand Down Expand Up @@ -388,7 +390,8 @@ impl GearApi {
.await
}

/// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path), but reads the program's state at the block identified by its hash.
/// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path),
/// but reads the program's state at the block identified by its hash.
pub async fn read_state_using_wasm_by_path_at<E: Encode, D: Decode>(
&self,
program_id: ProgramId,
Expand Down
147 changes: 0 additions & 147 deletions gclient/tests/state.rs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion gtest/src/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ use gear_common::{
LockId, Origin,
};
use gear_core::{
code::{Code, CodeAndId, InstrumentedCode, InstrumentedCodeAndId, TryNewCodeConfig},
code::InstrumentedCode,
gas_metering::{DbWeights, RentWeights, Schedule},
ids::{prelude::*, CodeId, MessageId, ProgramId, ReservationId},
memory::PageBuf,
Expand Down
Loading
Loading