Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core-code) Optimisation of read-write structures for code instrumentation #4274

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

refactor(core-code) Optimisation of read-write structures for code instrumentation #4274

wants to merge 21 commits into from

Conversation

Lazark0x
Copy link
Member

@Lazark0x Lazark0x commented Oct 1, 2024 •
edited
Loading

Code structure constructor now returns 3 parameters: InstrumentedCode, OriginalCode and CodeMetadata

CodeMetadata contains all the necessary data to infer the need for code instrumentation

Rewritten precharge to type-state pattern

@Lazark0x Lazark0x added the A0-pleasereview PR is ready to be reviewed by the team label Oct 1, 2024
@Lazark0x Lazark0x self-assigned this Oct 1, 2024
@Lazark0x Lazark0x requested a review from breathx October 1, 2024 22:07
breathx
breathx requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be refactored as discussed in dm

@breathx breathx added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A0-pleasereview PR is ready to be reviewed by the team labels Oct 7, 2024
@breathx breathx added the A0-pleasereview PR is ready to be reviewed by the team label Oct 18, 2024
@Lazark0x Lazark0x changed the title refactor(core-code) InstrumentedCode is made a member of the Code refactor(core-code) Optimisation of read-write structures for code instrumentation Oct 21, 2024
@Lazark0x Lazark0x removed the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Oct 21, 2024
ark0f
ark0f requested changes Oct 28, 2024
View reviewed changes
core/src/code/instrumented.rs Outdated Show resolved Hide resolved
core/src/code/attribution.rs Outdated Show resolved Hide resolved
core/src/code/instrumented.rs Outdated Show resolved Hide resolved
core/src/code/mod.rs Outdated Show resolved Hide resolved
core/src/code/config.rs Outdated Show resolved Hide resolved
pallets/gear/src/runtime_api.rs Outdated Show resolved Hide resolved
common/src/code_storage.rs Outdated Show resolved Hide resolved
core-processor/src/context.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
@breathx breathx added the A3-gotissues PR occurred to have issues after the review label Nov 4, 2024
@Lazark0x Lazark0x removed the A3-gotissues PR occurred to have issues after the review label Nov 5, 2024
@Lazark0x
Merge remote-tracking branch 'origin/master' into code-instrumentatio…
1a653bf 
…n-refactoring

# Conflicts:
#	ethexe/runtime/common/src/lib.rs
#	gtest/src/manager.rs
#	gtest/src/manager/block_exec.rs
#	pallets/gear-program/src/migrations/add_section_sizes.rs
#	pallets/gear-program/src/migrations/v12_program_code_id_migration.rs
#	pallets/gear/src/tests.rs
#	runtime/vara/src/migrations.rs
@Lazark0x
Merge remote-tracking branch 'origin/master' into code-instrumentatio…
cd4126f 
…n-refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx requested changes

@ark0f ark0f ark0f requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Lazark0x Lazark0x

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lazark0x @ark0f @breathx