Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ethexe): Initial fast sync protocol #4132

Merged
merged 66 commits into from
Aug 27, 2024
Merged

feat(ethexe): Initial fast sync protocol #4132

merged 66 commits into from
Aug 27, 2024

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Aug 8, 2024

No description provided.

@ark0f ark0f added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Aug 8, 2024
@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Aug 16, 2024
@ark0f ark0f requested review from grishasobol and ukint-vs August 16, 2024 20:33
@ark0f ark0f marked this pull request as ready for review August 16, 2024 20:42
@ark0f ark0f force-pushed the al/ethexe/req-resp branch from 91bdc4a to 8abe958 Compare August 16, 2024 20:44
grishasobol
grishasobol approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find any problems with this PR, just some remarks. Please add TODO if you do not wanna to fix in this PR some of them.

ethexe/db/src/database.rs Outdated Show resolved Hide resolved
ethexe/network/src/db_sync/ongoing.rs Show resolved Hide resolved
ethexe/network/src/db_sync/ongoing.rs Show resolved Hide resolved
ethexe/network/src/db_sync/ongoing.rs Show resolved Hide resolved
ethexe/network/src/lib.rs Outdated Show resolved Hide resolved
ethexe/network/src/lib.rs Show resolved Hide resolved
ethexe/network/src/db_sync/mod.rs Show resolved Hide resolved
breathx
breathx approved these changes Aug 22, 2024
View reviewed changes
ethexe/common/src/db.rs Show resolved Hide resolved
ethexe/network/src/utils.rs Show resolved Hide resolved
ethexe/network/src/db_sync/mod.rs Show resolved Hide resolved
ethexe/network/src/db_sync/mod.rs Outdated Show resolved Hide resolved
ethexe/network/src/db_sync/mod.rs Show resolved Hide resolved
ukint-vs
ukint-vs approved these changes Aug 23, 2024
View reviewed changes
ethexe/network/src/db_sync/mod.rs Show resolved Hide resolved
@ark0f ark0f merged commit b7c2683 into master Aug 27, 2024
10 checks passed
@ark0f ark0f deleted the al/ethexe/req-resp branch August 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

@grishasobol grishasobol grishasobol approved these changes

Assignees

@ark0f ark0f

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ark0f @grishasobol @breathx @ukint-vs