-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Use debug
& release
profiles
#3616
Conversation
1db1c1b
to
3a20bfb
Compare
3a20bfb
to
81cd3ee
Compare
bcd8409
to
fe0ad6f
Compare
ff19faf
to
8477705
Compare
8477705
to
edd4bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason of using release profile in gcli tests is that testing with release built node runs faster, so since under debug profile with opt-level = 3
gcli can still pass the tests, everything works with this PR
debug
profiledebug
& release
profiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove trash branches and commented code
- Revert fix of authorship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🥇
Awaiting for #3803 |
Merged |
Rust:
gring
'sverbose
andvanity
flags have the same shortv
namegcli
uses incorrect type forverbose
flaggcli
uses debug node for tests and invalid profile flag to build demopallet-gear
andpallet-gear-voucher
common/runtime-benchmarks
feature inpallet-gear-voucher
CI:
macos
andwin-native
builds cancelable