Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use debug & release profiles #3616

Merged
merged 64 commits into from
Mar 13, 2024
Merged

chore(ci): Use debug & release profiles #3616

merged 64 commits into from
Mar 13, 2024

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Dec 22, 2023

Rust:

  • Fix gring's verbose and vanity flags have the same short v name
  • Fix gcli uses incorrect type for verbose flag
  • Fix gcli uses debug node for tests and invalid profile flag to build demo
  • Make benchmark listing consistent between pallet-gear and pallet-gear-voucher
  • Fix missing common/runtime-benchmarks feature in pallet-gear-voucher

CI:

  • Use debug profile in some bash scripts
  • Add labels to run native Windows and release builds in PR
  • Add fast benchmark check before long running check
  • Use dynamic matrix to run build in release and debug modes
  • Make macos and win-native builds cancelable
  • Remove obsolete caching

@ark0f ark0f added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D5-tooling Helper tools and utilities A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Dec 22, 2023
@ark0f ark0f force-pushed the al/debug-build-ci branch from 1db1c1b to 3a20bfb Compare December 22, 2023 02:02
@ark0f ark0f force-pushed the al/debug-build-ci branch from 3a20bfb to 81cd3ee Compare December 22, 2023 21:47
@ark0f ark0f force-pushed the al/debug-build-ci branch from bcd8409 to fe0ad6f Compare December 22, 2023 22:16
@ark0f ark0f force-pushed the al/debug-build-ci branch 3 times, most recently from ff19faf to 8477705 Compare December 24, 2023 20:23
@ark0f ark0f force-pushed the al/debug-build-ci branch from 8477705 to edd4bdf Compare December 24, 2023 20:32
@ark0f ark0f added E2-forcemacos Force CI to run macOS build in PR E0-forcecoverage Force CI to run coverage in PR labels Dec 24, 2023
@ark0f ark0f changed the title chore(ci): Debug assertions chore(ci): Use debug profile Dec 24, 2023
Copy link
Contributor

@clearloop clearloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason of using release profile in gcli tests is that testing with release built node runs faster, so since under debug profile with opt-level = 3 gcli can still pass the tests, everything works with this PR

@ark0f ark0f changed the title chore(ci): Use debug profile chore(ci): Use debug & release profiles Feb 12, 2024
@ark0f ark0f removed the A5-dontmerge PR should not be merged yet label Feb 12, 2024
@breathx breathx added the A5-dontmerge PR should not be merged yet label Mar 4, 2024
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove trash branches and commented code
  • Revert fix of authorship

.github/workflows/CI.yaml Show resolved Hide resolved
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇

@ark0f ark0f requested a review from breathx March 12, 2024 15:03
@ark0f ark0f removed the A5-dontmerge PR should not be merged yet label Mar 12, 2024
.github/workflows/build-win-native.yml Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Mar 12, 2024
@ark0f
Copy link
Member Author

ark0f commented Mar 12, 2024

Awaiting for #3803

@ekovalev
Copy link
Member

Awaiting for #3803

Merged

@NikVolf NikVolf added A0-pleasereview PR is ready to be reviewed by the team and removed A2-mergeoncegreen PR is ready to merge after CI passes labels Mar 13, 2024
@breathx breathx merged commit 81d18cc into master Mar 13, 2024
16 checks passed
@breathx breathx deleted the al/debug-build-ci branch March 13, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team D5-tooling Helper tools and utilities E1-forcenatwin Force CI to run native Windows build in PR E2-forcemacos Force CI to run macOS build in PR E3-forcerelease Force CI to run release build in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants