Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-gen): avoid infinite wait-wake for loose syscalls #3615

Merged
merged 41 commits into from
Feb 7, 2024
Merged

feat(wasm-gen): avoid infinite wait-wake for loose syscalls #3615

merged 41 commits into from
Feb 7, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Dec 21, 2023 •
edited
Loading

Resolves #3273

Also:

  • added MemoryLayout struct that will never be overwritten during fuzzing
  • fixed bug with mutable array

TODO:

@StackOverflowExcept1on StackOverflowExcept1on added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Dec 21, 2023
@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team D5-tooling Helper tools and utilities and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jan 16, 2024
techraed
techraed reviewed Jan 18, 2024
View reviewed changes
utils/wasm-gen/src/generator/entry_points.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/syscalls/invocator.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/entry_points.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/config.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/syscalls/invocator.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/generator/syscalls/invocator.rs Outdated Show resolved Hide resolved
breathx
breathx approved these changes Feb 1, 2024
View reviewed changes
utils/wasm-gen/src/config.rs Outdated Show resolved Hide resolved
utils/wasm-gen/src/config/syscalls.rs Outdated Show resolved Hide resolved
techraed
techraed approved these changes Feb 1, 2024
View reviewed changes
utils/wasm-gen/src/memory_layout.rs Outdated Show resolved Hide resolved
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Feb 1, 2024
@StackOverflowExcept1on StackOverflowExcept1on merged commit 117337e into master Feb 7, 2024
10 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/wasm-gen-deadlocks branch February 7, 2024 17:52
breathx pushed a commit that referenced this pull request Feb 27, 2024
@StackOverflowExcept1on @breathx
feat(wasm-gen): avoid infinite wait-wake for loose syscalls (#3615)
b7741a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@techraed techraed techraed approved these changes

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid infinite wait-wake patterns in wasm-gen
3 participants
@StackOverflowExcept1on @techraed @breathx