Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump gear-dlmalloc for free_range support #3611

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

holykol
Copy link
Contributor

@holykol holykol commented Dec 20, 2023

Bump allocator to version that uses new free_range call.

@gear-tech/dev

@holykol holykol requested a review from clearloop December 20, 2023 17:24
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a 0.1.5 tag there too: https://github.com/gear-tech/dlmalloc-rust/tags

@shamilsan shamilsan added the A0-pleasereview PR is ready to be reviewed by the team label Dec 20, 2023
@breathx
Copy link
Member

breathx commented Dec 21, 2023

Need to add a 0.1.5 tag there too: https://github.com/gear-tech/dlmalloc-rust/tags

We've never tagged it before. Should we?

@holykol
Copy link
Contributor Author

holykol commented Dec 21, 2023

@breathx

We've never tagged it before. Should we?

I've already published 0.1.5 on crates.io, so tagging just makes it consistent. If anything, it should have been a major version change because it technically breaks backwards compatibility by relying on a new syscall

Cargo.toml Outdated Show resolved Hide resolved
@holykol holykol requested a review from shamilsan December 22, 2023 17:49
Cargo.toml Outdated Show resolved Hide resolved
@holykol holykol force-pushed the holykol/bump-dlmalloc branch from 3b4c7dd to c6f5444 Compare December 27, 2023 14:26
@holykol holykol merged commit 559afdc into master Dec 27, 2023
11 checks passed
@holykol holykol deleted the holykol/bump-dlmalloc branch December 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants