Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gtest): process time-limited wait messages #3605

Merged
merged 2 commits into from
Dec 22, 2023
Merged

feat(gtest): process time-limited wait messages #3605

merged 2 commits into from
Dec 22, 2023

Conversation

shamilsan
Copy link
Contributor

Now it is possible to test time-limited wait messages (gstd::exec::wait_for / gstd::exec::wait_up_to) using gtest. These messages are processed after calling gtest::System::spend_blocks.

@gear-tech/dev

@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities labels Dec 19, 2023
breathx
breathx approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test for that?

@shamilsan
Copy link
Contributor Author

Any test for that?

Excellent idea, added it in 9f0464e

@shamilsan shamilsan merged commit a650c80 into master Dec 22, 2023
11 checks passed
@shamilsan shamilsan deleted the sy-gtest-wait-for branch December 22, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@gshep gshep gshep approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamilsan @gshep @breathx