Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Allow waking the same message between waits #3475

Merged
merged 61 commits into from
Feb 27, 2024
Merged

fix(core): Allow waking the same message between waits #3475

merged 61 commits into from
Feb 27, 2024

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Nov 7, 2023

Resolves #2763

@reviewer-or-team

@mqxf mqxf requested review from techraed and breathx and removed request for techraed November 7, 2023 11:43
@mqxf mqxf added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed C0-bug Something isn't working labels Nov 7, 2023
techraed
techraed reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to now seems ok. Need to implement migrations.

breathx
breathx requested changes Nov 10, 2023
View reviewed changes
core/src/message/context.rs Outdated Show resolved Hide resolved
core/src/message/context.rs Show resolved Hide resolved
@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Nov 13, 2023
breathx
breathx requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You don't need to store awakening at all
  2. You need runtime migrations

@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 14, 2023
@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 28, 2023
@mqxf mqxf requested review from breathx and techraed November 28, 2023 11:41
@NikVolf
Copy link
Member

NikVolf commented Nov 29, 2023

Rebase this properly to master to remove all the commits above

ark0f
ark0f previously requested changes Feb 2, 2024
View reviewed changes
pallets/gear-messenger/src/migrations.rs Outdated Show resolved Hide resolved
core/src/message/stored.rs Show resolved Hide resolved
pallets/gear-messenger/src/lib.rs Show resolved Hide resolved
pallets/gear-messenger/src/migrations.rs Outdated Show resolved Hide resolved
pallets/gear-messenger/src/migrations.rs Outdated Show resolved Hide resolved
pallets/gear-messenger/src/migrations.rs Outdated Show resolved Hide resolved
@mqxf mqxf mentioned this pull request Feb 7, 2024
Open
@breathx breathx requested a review from ark0f February 12, 2024 07:05
@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Feb 16, 2024
@ark0f ark0f self-assigned this Feb 19, 2024
@ark0f ark0f requested a review from breathx February 19, 2024 15:55
@breathx breathx dismissed ark0f’s stale review February 27, 2024 06:35

Reviewer has already took place in a code editing

@breathx breathx merged commit cf483b5 into master Feb 27, 2024
10 checks passed
@breathx breathx deleted the ms/issue-2763 branch February 27, 2024 06:35
@breathx breathx mentioned this pull request Feb 27, 2024
Merged
breathx added a commit that referenced this pull request Feb 27, 2024
@mqxf @ark0f @breathx
fix(core): Allow waking the same message between waits (#3475)
f06cbda 
Co-authored-by: Arsenii Lyashenko <[email protected]>
Co-authored-by: Dmitry Novikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@techraed techraed techraed approved these changes

@ark0f ark0f Awaiting requested review from ark0f

Assignees

@ark0f ark0f

Labels
A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow waking the same message between waits
5 participants
@mqxf @NikVolf @breathx @ark0f @techraed