Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'free_range' syscall #3467

Merged
merged 51 commits into from
Dec 3, 2023
Merged

feat: Add 'free_range' syscall #3467

merged 51 commits into from
Dec 3, 2023

Conversation

holykol
Copy link
Contributor

@holykol holykol commented Nov 1, 2023

Resolves #3466

@grishasobol

@holykol holykol self-assigned this Nov 1, 2023
@holykol holykol force-pushed the holykol/free-range-syscall branch from f5ca687 to 1cd654b Compare November 1, 2023 14:03
techraed
techraed reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update syscalls params config in wasm-gen and a corresponding code so free_range will receive some "real" values when executing wasm from wasm-gen.

@grishasobol grishasobol added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed A3-gotissues PR occurred to have issues after the review labels Nov 1, 2023
@grishasobol grishasobol changed the title feat: Add 'free_range' syscall feat: Add 'free_range' syscall (DRAFT) Nov 1, 2023
@holykol holykol changed the title feat: Add 'free_range' syscall (DRAFT) Draft: feat: Add 'free_range' syscall Nov 1, 2023
@holykol holykol force-pushed the holykol/free-range-syscall branch 2 times, most recently from 2411242 to 74385df Compare November 1, 2023 16:50
@holykol holykol force-pushed the holykol/free-range-syscall branch from 74385df to 72e0a39 Compare November 1, 2023 17:11
breathx
breathx reviewed Nov 2, 2023
View reviewed changes
core-backend/src/memory.rs Outdated Show resolved Hide resolved
@holykol holykol requested a review from techraed November 2, 2023 23:57
@holykol holykol changed the title Draft: feat: Add 'free_range' syscall feat: Add 'free_range' syscall Nov 3, 2023
grishasobol
grishasobol requested changes Nov 5, 2023
View reviewed changes
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
core/src/costs.rs Outdated Show resolved Hide resolved
core-backend/src/funcs.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/syscalls.rs Outdated Show resolved Hide resolved
pallets/gear/src/weights.rs Outdated Show resolved Hide resolved
utils/runtime-fuzzer/src/gear_calls.rs Outdated Show resolved Hide resolved
breathx
breathx reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also consider possible renaming like free_range -> free_many @grishasobol

core/src/env.rs Show resolved Hide resolved
core/src/memory.rs Outdated Show resolved Hide resolved
core-backend/src/memory.rs Show resolved Hide resolved
@holykol
Copy link
Contributor Author

holykol commented Nov 6, 2023

I'd also consider possible renaming like free_range -> free_many

Just from the name I would think that this function accepts arbitrary amount of unrelated pages. E.g. free_many(1, 4, 55, 2)

@holykol holykol requested a review from ark0f November 21, 2023 18:19
ark0f
ark0f requested changes Nov 24, 2023
View reviewed changes
core-processor/src/ext.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/tests/syscalls_integrity.rs Outdated Show resolved Hide resolved
@holykol holykol requested a review from ark0f November 27, 2023 16:19
breathx
breathx approved these changes Dec 2, 2023
View reviewed changes
core-backend/src/funcs.rs Outdated Show resolved Hide resolved
core-backend/src/memory.rs Show resolved Hide resolved
core-processor/src/ext.rs Show resolved Hide resolved
core/src/memory.rs Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Dec 2, 2023

@ark0f re review please

ark0f
ark0f requested changes Dec 2, 2023
View reviewed changes
core-backend/src/funcs.rs Outdated Show resolved Hide resolved
core-processor/src/ext.rs Show resolved Hide resolved
utils/wasm-gen/src/generator/syscalls/invocator.rs Outdated Show resolved Hide resolved
@holykol holykol merged commit 5b4a419 into master Dec 3, 2023
10 checks passed
@holykol holykol deleted the holykol/free-range-syscall branch December 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed left review comments

@grishasobol grishasobol grishasobol approved these changes

@breathx breathx breathx approved these changes

@ark0f ark0f ark0f approved these changes

Assignees

@holykol holykol

Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement free_range syscall
6 participants
@holykol @breathx @grishasobol @ark0f @techraed @shamilsan