Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade rust version to nightly-2023-09-18 #3451

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Oct 26, 2023

it should fix fuzzer & CI

disadvantages: needless_pass_by_ref_mut warnings (#3452)

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team E0-forcecoverage Force CI to run coverage in PR labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 352 lines in your changes are missing coverage. Please review.

Comparison is base (bd292dc) 70.72% compared to head (1f8a024) 69.63%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   70.72%   69.63%   -1.10%     
==========================================
  Files         223      211      -12     
  Lines       24439    29101    +4662     
==========================================
+ Hits        17285    20264    +2979     
- Misses       7154     8837    +1683     
Files Coverage Δ
common/src/paused_program_storage.rs 91.13% <100.00%> (+0.94%) ⬆️
core-backend/src/env.rs 98.67% <100.00%> (+3.27%) ⬆️
core-backend/src/error.rs 89.47% <ø> (ø)
core-backend/src/runtime.rs 96.80% <100.00%> (-0.06%) ⬇️
core-processor/src/common.rs 85.18% <ø> (ø)
core-processor/src/configs.rs 100.00% <ø> (ø)
core-processor/src/context.rs 89.09% <100.00%> (+0.20%) ⬆️
core-processor/src/executor.rs 93.91% <100.00%> (-0.20%) ⬇️
core-processor/src/processing.rs 99.70% <100.00%> (+<0.01%) ⬆️
core/src/costs.rs 92.59% <100.00%> (+12.21%) ⬆️
... and 70 more

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StackOverflowExcept1on StackOverflowExcept1on merged commit 8f781af into master Oct 28, 2023
12 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/pin-rust branch October 28, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team E0-forcecoverage Force CI to run coverage in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants