Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pallet-gear, wasm-gen): Remove stack limiter to decrease unnecessary errors from wasmi #3434

Merged
merged 4 commits into from
Oct 22, 2023
Merged

refactor(pallet-gear, wasm-gen): Remove stack limiter to decrease unnecessary errors from wasmi #3434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e121cc
Fix too much `wasm 'unreachable'...` errors occurrences
techraed Oct 21, 2023
8065fc1
[skip ci] Add comment
techraed Oct 21, 2023
0e3228d
Trigger CI
techraed Oct 21, 2023
e7061ca
Update pallets/gear/src/schedule.rs
breathx Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pallets/gear/src/schedule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,8 @@ impl Default for Limits {
// To avoid potential stack overflow problems we have a panic in sandbox in case,
// execution is ended with stack overflow error. So, process queue execution will be
// stopped and we will be able to investigate the problem and decrease this constant if needed.
stack_height: Some(20_000),
// TODO #3435. Disabled stack height is a temp solution.
stack_height: cfg!(not(feature = "fuzz")).then_some(20_000),
globals: 256,
locals: 1024,
parameters: 128,
Expand Down
2 changes: 1 addition & 1 deletion scripts/src/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ run_fuzzer() {
cd $ROOT_DIR/utils/runtime-fuzzer

if [ "$3" = "wlogs" ]; then
LOG_TARGETS="debug,syscalls,gear_wasm_gen=trace,runtime_fuzzer=trace,gear_core_backend=trace"
LOG_TARGETS="debug,syscalls,runtime::sandbox=trace,gear_wasm_gen=trace,runtime_fuzzer=trace,gear_core_backend=trace"
else
LOG_TARGETS="off"
fi
Expand Down