Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gstd, backend): Introduce gr_env_vars sys-call #3403

Merged
merged 20 commits into from
Oct 23, 2023
Merged

feat(gstd, backend): Introduce gr_env_vars sys-call #3403

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e3694a6
Introduce gr_exec_settings sys-call
DennisInSky Oct 11, 2023
a956b69
Address PR comment and update gsdk meta
DennisInSky Oct 11, 2023
3cdd83a
Merge remote-tracking branch 'origin/master' into dd/gr-exec-settings
DennisInSky Oct 12, 2023
cddc847
Address PR comments
DennisInSky Oct 17, 2023
aa8086a
Merge remote-tracking branch 'origin/master' into dd/gr-exec-settings
DennisInSky Oct 17, 2023
a41e118
Fix compilation
DennisInSky Oct 17, 2023
b6c763e
Move out ExecSettings struct into gsys
DennisInSky Oct 17, 2023
74c225b
Fix compilation
DennisInSky Oct 17, 2023
7e5c304
Introduce ParamType::Version and PtrType::Buffer in wasm-instrument
DennisInSky Oct 18, 2023
36a97e2
Merge remote-tracking branch 'origin/master' into dd/gr-exec-settings
DennisInSky Oct 18, 2023
6a73b03
Update wasm-gen config for new ParamType::Version
DennisInSky Oct 18, 2023
e3e27d8
Address PR comments
DennisInSky Oct 19, 2023
e3c3179
Add comment mentioning some issue
DennisInSky Oct 19, 2023
fd40986
Merge branch 'master' into dd/gr-exec-settings
DennisInSky Oct 23, 2023
2e38bc3
Rename exec_settings into env_vars
DennisInSky Oct 23, 2023
e484f42
Merge branch 'master' into dd/gr-exec-settings
DennisInSky Oct 23, 2023
161c31d
Forgotten change
DennisInSky Oct 23, 2023
aad8751
Switch off fuzzer and loader for the gr_env_vars syscall
DennisInSky Oct 23, 2023
6b6b9e7
Forgotten change
DennisInSky Oct 23, 2023
a12d961
Merge branch 'master' into dd/gr-exec-settings
DennisInSky Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions utils/wasm-instrument/src/syscalls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,21 +287,13 @@ impl SysCallName {
SysCallSignature::gr([Ptr(PtrInfo::new_mutable(PtrType::ErrorWithSignalCode))])
}
Self::MessageId => SysCallSignature::gr([Ptr(PtrInfo::new_mutable(PtrType::Hash))]),
Self::ExecSettings => SysCallSignature::gr([
Size,
// The PtrType::BufferStart doesn't work here as it requires length_param_idx
// Should we introduce something like PtrType::Buffer
Ptr(PtrInfo::new_mutable(PtrType::BlockNumber)),
]),
Self::ExecSettings => {
SysCallSignature::gr([Version, Ptr(PtrInfo::new_mutable(PtrType::Buffer))])
}
Self::Read => SysCallSignature::gr([
MessagePosition,
Size,
// TODO #3375, the PtrType::BlockNumber is incorrect here.
DennisInSky marked this conversation as resolved.
Show resolved Hide resolved
// Should be:
// Ptr(PtrInfo::new_mutable(PtrType::BufferStart {
// length_param_idx: 1,
// }))
DennisInSky marked this conversation as resolved.
Show resolved Hide resolved
Ptr(PtrInfo::new_mutable(PtrType::BlockNumber)),
Ptr(PtrInfo::new_mutable(PtrType::Buffer)),
Ptr(PtrInfo::new_mutable(PtrType::ErrorCode)),
]),
Self::Reply => SysCallSignature::gr([
Expand Down Expand Up @@ -534,6 +526,7 @@ pub enum ParamType {
Handler, // i32 handler number
Alloc, // i32 alloc pages
Free, // i32 free page
Version, // i32 version number of exec settings
DennisInSky marked this conversation as resolved.
Show resolved Hide resolved
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
Expand Down Expand Up @@ -561,6 +554,7 @@ pub enum PtrType {
BlockNumber,
BlockTimestamp,
BufferStart { length_param_idx: usize },
Buffer,
Hash,
Gas,
Length,
Expand Down Expand Up @@ -598,6 +592,7 @@ impl PtrType {
BlockNumber
| BlockTimestamp
| BufferStart { .. }
| Buffer
| Hash
| Gas
| Length
Expand Down