Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(runtime): Separate prepaid transactions into specific pallet-gear-voucher call #3401

Merged
merged 7 commits into from
Oct 17, 2023
Merged

feat!(runtime): Separate prepaid transactions into specific pallet-gear-voucher call #3401

merged 7 commits into from
Oct 17, 2023

Conversation

breathx
Copy link
Member

@breathx breathx commented Oct 11, 2023

Part of #3399

@breathx breathx added the A0-pleasereview PR is ready to be reviewed by the team label Oct 11, 2023
ekovalev
ekovalev reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@ekovalev ekovalev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. But can it be the case that we might want to dispatch prepaid extrinsics from more than one pallet? This implementation implies there can only be a single VoucherCallDispatcher, does it?

@breathx
Copy link
Member Author

breathx commented Oct 17, 2023

Makes sense. But can it be the case that we might want to dispatch prepaid extrinsics from more than one pallet? This implementation implies there can only be a single VoucherCallDispatcher, does it?

Discussed personally.
You can anytime implement the trait on tuple of the pallets in runtime and use different calls for processing, so its not a problem.

@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Oct 17, 2023
@breathx breathx changed the title feat(runtime): Separate prepaid transactions into specific pallet-gear-voucher call feat!(runtime): Separate prepaid transactions into specific pallet-gear-voucher call Oct 17, 2023
@breathx breathx merged commit 4d332e7 into master Oct 17, 2023
@breathx breathx deleted the dn-voucher-call branch October 17, 2023 10:05
@NikVolf
Copy link
Member

NikVolf commented Oct 17, 2023

@osipov-mit gear-js breaking i guess

@NikVolf NikVolf requested a review from osipov-mit October 17, 2023 14:07
@osipov-mit osipov-mit mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@ekovalev ekovalev ekovalev approved these changes

@osipov-mit osipov-mit Awaiting requested review from osipov-mit

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breathx @NikVolf @ekovalev