Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-fuzzer): reduce the range of pages num for free syscall #3400

Closed
wants to merge 1 commit into from
Closed

fix(runtime-fuzzer): reduce the range of pages num for free syscall #3400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/runtime-fuzzer/src/gear_calls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ fn config(

let mut params_config = SysCallsParamsConfig::default();
params_config.add_rule(ParamType::Alloc, (10..=20).into());
params_config.add_rule(ParamType::Free, (initial_pages..=initial_pages + 35).into());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open please an issue for making more complex tests for free. As current generator produces multiple alloc calls allocating minimum 10 pages, would be nice to free those very possibly unused in current fuzzer pages, instead of freeing pages with active data for a program that mostly uses them. I afraid these changes can lower amount of executions for update_pages_data in journal notes handler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it open @StackOverflowExcept1on ?

params_config.add_rule(ParamType::Free, (initial_pages..=initial_pages + 1).into());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb at least 2-4?


let existing_addresses = NonEmpty::collect(
programs
Expand Down