feat(vara): add TransactionPaymentCallApi #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukint-vs
force-pushed
the
vs/vara-tx-call-api
branch
from
6c91d79 to
a254ad4
Compare
ukint-vs
force-pushed
the
vs/vara-tx-call-api
branch
from
a254ad4 to
c80e4d5
Compare
|
What's wrong with https://github.com/gear-tech/gear/blob/master/runtime/common/src/apis.rs#L130? @breathx, we definitely need to merge the runtime api implementations in one place. It very much has to do with the #3380, maybe you could make a quick fix for this in that PR, as well? |
This is one of the 2 tx payment apis. One is general and second is CallApi. |
Ok, got it. Then it's even more logical to move the "common" apis back to Vara runtime apis. |
ekovalev
approved these changes
Oct 8, 2023
gshep
approved these changes
Oct 9, 2023
shamilsan
added
the
B1-releasenotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
@reviewer-or-team