Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wasm-gen): Clean-up wasm-gen #3384

Merged
merged 19 commits into from
Oct 10, 2023
Merged

refactor(wasm-gen): Clean-up wasm-gen #3384

merged 19 commits into from
Oct 10, 2023

Conversation

techraed
Copy link
Member

@techraed techraed commented Oct 2, 2023

General clean-up after including various features to the wasm-gen.

  • Rename all sys-call and sys_call to syscall (there was a mix of syscall and sys_call in the code)
  • Clean-up syscalls imports generator
  • Fix bug with precise sys-calls insertion: generated N precise sys-calls, but only one was saved in syscalls imports map and, as a result, invocation was done only for one.
  • Set min/max funcs param in SelectableParams to std::num::NonZeroUsize as generators implementation relies on underlying wasm having at least one internal function generated
  • Reduce allocations in invocator
  • Adjust logs
  • Refactor syscalls_imports map value: amount must be either None or Some(NonZeroU32) or something simillar

@techraed techraed added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D4-test Autotests, and examples D5-tooling Helper tools and utilities labels Oct 2, 2023
@techraed techraed self-assigned this Oct 2, 2023
@breathx
Copy link
Member

breathx commented Oct 4, 2023

Part of #3361

@techraed techraed changed the title refactor(wasm-gen): Clean-up fuzzer refactor(wasm-gen): Clean-up wasm-gen\ Oct 5, 2023
@techraed techraed changed the title refactor(wasm-gen): Clean-up wasm-gen\ refactor(wasm-gen): Clean-up wasm-gen Oct 5, 2023
@techraed techraed marked this pull request as ready for review October 5, 2023 18:52
@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Oct 7, 2023
utils/wasm-gen/src/generator.rs Outdated Show resolved Hide resolved
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Oct 9, 2023
@techraed techraed merged commit 5b931e2 into master Oct 10, 2023
13 checks passed
@techraed techraed deleted the st-clean-up-wasm-gen branch October 10, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes D4-test Autotests, and examples D5-tooling Helper tools and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants