-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(wasm-gen): Clean-up wasm-gen #3384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
added
A1-inprogress
Issue is in progress or PR draft is not ready to be reviewed
D4-test
Autotests, and examples
D5-tooling
Helper tools and utilities
labels
Oct 2, 2023
…ation, restructure functions
Part of #3361 |
techraed
changed the title
refactor(wasm-gen): Clean-up fuzzer
refactor(wasm-gen): Clean-up wasm-gen\
Oct 5, 2023
techraed
changed the title
refactor(wasm-gen): Clean-up wasm-gen\
refactor(wasm-gen): Clean-up wasm-gen
Oct 5, 2023
techraed
added
A0-pleasereview
PR is ready to be reviewed by the team
and removed
A1-inprogress
Issue is in progress or PR draft is not ready to be reviewed
labels
Oct 7, 2023
mertwole
approved these changes
Oct 8, 2023
StackOverflowExcept1on
approved these changes
Oct 8, 2023
techraed
added
A2-mergeoncegreen
PR is ready to merge after CI passes
and removed
A0-pleasereview
PR is ready to be reviewed by the team
labels
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A2-mergeoncegreen
PR is ready to merge after CI passes
D4-test
Autotests, and examples
D5-tooling
Helper tools and utilities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General clean-up after including various features to the
wasm-gen
.sys-call
andsys_call
tosyscall
(there was a mix ofsyscall
andsys_call
in the code)SelectableParams
tostd::num::NonZeroUsize
as generators implementation relies on underlying wasm having at least one internal function generatedsyscalls_imports
map value: amount must be eitherNone
orSome(NonZeroU32)
or something simillar