Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lazy-pages): Implement generic storage #3379

Merged
merged 26 commits into from
Nov 15, 2023
Merged

feat(lazy-pages): Implement generic storage #3379

merged 26 commits into from
Nov 15, 2023

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Sep 29, 2023 •
edited
Loading

Resolves #3299

Awaiting #3166

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node labels Sep 29, 2023
@ark0f ark0f changed the title refactor: Implement generic lazy-pages storage refactor(lazy-pages): Implement generic storage Sep 29, 2023
@ark0f ark0f changed the title refactor(lazy-pages): Implement generic storage feat(lazy-pages): Implement generic storage Sep 29, 2023
gshep
gshep reviewed Oct 2, 2023
View reviewed changes
lazy-pages/src/lib.rs Outdated Show resolved Hide resolved
breathx
breathx requested changes Oct 15, 2023
View reviewed changes
runtime-interface/src/lib.rs Show resolved Hide resolved
runtime-interface/src/lib.rs Show resolved Hide resolved
runtime-interface/src/lib.rs Outdated Show resolved Hide resolved
lazy-pages/src/lib.rs Show resolved Hide resolved
lazy-pages/src/lib.rs Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Show resolved Hide resolved
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
gtest/src/system.rs Outdated Show resolved Hide resolved
@NikVolf
Copy link
Member

NikVolf commented Oct 16, 2023

@grishasobol please review

grishasobol
grishasobol reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to merge gshep triple map first then this PR

lazy-pages/src/process.rs Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
@breathx breathx added the A5-dontmerge PR should not be merged yet label Oct 16, 2023
@breathx
Copy link
Member

breathx commented Oct 29, 2023

Blocker issue now fixed @ark0f

@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team A5-dontmerge PR should not be merged yet labels Oct 29, 2023
ark0f added 5 commits October 30, 2023 17:09
@ark0f
Merge remote-tracking branch 'origin/master' into al/lazy-pages-gener…
1168b88 
…ic-storage

# Conflicts:
#	Cargo.lock
#	gtest/Cargo.toml
#	gtest/src/manager.rs
#	lazy-pages/interface/src/lib.rs
#	lazy-pages/src/lib.rs
#	runtime-interface/Cargo.toml
#	runtime-interface/src/lib.rs
@ark0f
Fix after-merge mess
0a62412
@ark0f
Simplify key parsing
fc9f87d
@ark0f
Rename trait
db35ef3
@ark0f
Remove page_sizes field in exec ctx
c71d827
@ark0f ark0f requested a review from breathx October 30, 2023 15:41
@ark0f ark0f requested a review from grishasobol October 30, 2023 15:41
@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Oct 30, 2023
grishasobol
grishasobol requested changes Nov 5, 2023
View reviewed changes
Copy link
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also making so big changes in binary you must check old runtimes. So please sync (not fast) vara and vara-test from the beginning.

Good work 🤟

runtime-interface/src/lib.rs Show resolved Hide resolved
runtime-interface/src/lib.rs Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
lazy-pages/Cargo.toml Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Show resolved Hide resolved
lazy-pages/src/common.rs Show resolved Hide resolved
lazy-pages/src/process.rs Show resolved Hide resolved
@ark0f ark0f requested a review from grishasobol November 7, 2023 23:07
@breathx
Copy link
Member

breathx commented Nov 10, 2023

@grishasobol re review pls sir

@grishasobol
Copy link
Member

@grishasobol re review pls sir

There are some not closed conversion, which must be solved before

grishasobol
grishasobol approved these changes Nov 13, 2023
View reviewed changes
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
lazy-pages/src/common.rs Outdated Show resolved Hide resolved
breathx
breathx approved these changes Nov 14, 2023
View reviewed changes
lazy-pages/src/common.rs Show resolved Hide resolved
lazy-pages/src/common.rs Show resolved Hide resolved
@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Nov 14, 2023
@ark0f ark0f merged commit 9650de2 into master Nov 15, 2023
10 checks passed
@ark0f ark0f deleted the al/lazy-pages-generic-storage branch November 15, 2023 19:26
mqxf pushed a commit that referenced this pull request Nov 27, 2023
@ark0f @mqxf
feat(lazy-pages): Implement generic storage (#3379)
fae56b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep left review comments

@breathx breathx breathx approved these changes

@grishasobol grishasobol grishasobol approved these changes

@ukint-vs ukint-vs Awaiting requested review from ukint-vs

Assignees

@ark0f ark0f

Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic storage access in lazy-pages
5 participants
@ark0f @NikVolf @breathx @grishasobol @gshep