feat(rpc): Add RPC call to query inflation and ROI #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekovalev
added
A0-pleasereview
ukint-vs
approved these changes
Sep 16, 2023
NikVolf
approved these changes
Sep 18, 2023
breathx
reviewed
Sep 18, 2023
Comment on lines
+3
to
+8
| version = "1.0.0" | ||
| authors.workspace = true | ||
| edition.workspace = true | ||
| license.workspace = true | ||
| homepage = "https://gear-tech.io" | ||
| repository = "https://github.com/gear-tech/gear" |
There was a problem hiding this comment.
Suggested change
| version = "1.0.0" | |
| authors.workspace = true | |
| edition.workspace = true | |
| license.workspace = true | |
| homepage = "https://gear-tech.io" | |
| repository = "https://github.com/gear-tech/gear" | |
| version.workspace = true | |
| authors.workspace = true | |
| edition.workspace = true | |
| license.workspace = true | |
| homepage.workspace = true | |
| repository.workspace = true |
| @@ -0,0 +1,19 @@ | |||
| [package] | |||
| name = "pallet-gear-staking-rewards-rpc-runtime-api" | |||
| version = "1.0.0" | |||
| impl From<Error> for i32 { | ||
| fn from(e: Error) -> i32 { | ||
| match e { | ||
| Error::RuntimeError => 1, |
There was a problem hiding this comment.
why?
decode_error => 0,
runtime_error => 1, isn't it?
|
Merged before review, but anyway please pay attention on the small fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New RPC call in
pallet-gear-staking-rewards(and respectiveruntime-apicall) to query current inflation and ROI values (either at current best block or any block hash in the past).This is needed to be able to correctly display staking-related numbers in UI.
Note: even though technically inflation is 0 (any newly minted tokens at the end of an era are offset against the inflation pool), the value returned from the call is still relevant as an indicator of how close/far we are from the ideal staking ratio.