Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pallet-gear): Allow calculate_gas_info on terminated program. #3278

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Sep 15, 2023

Resolves #3008.

@reviewer-or-team

@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node C2-refactoring Refactoring proposal labels Sep 15, 2023
@mqxf mqxf requested review from techraed and breathx September 15, 2023 14:49
@mqxf mqxf requested a review from techraed September 18, 2023 14:42
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Sep 18, 2023
pallets/gear/src/tests.rs Outdated Show resolved Hide resolved
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove copy-paste in runtime_apis.rs on line 146

@mqxf mqxf merged commit 5166948 into master Sep 18, 2023
8 checks passed
@mqxf mqxf deleted the ms/issue-3008 branch September 18, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes C2-refactoring Refactoring proposal D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting gas info rpc call must not panic when message destination is inactive program
3 participants