Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Merge core-backend-common and core-backend-sandbox #3249

Merged
merged 46 commits into from
Sep 26, 2023
Merged

refactor: Merge core-backend-common and core-backend-sandbox #3249

merged 46 commits into from
Sep 26, 2023

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Sep 11, 2023 •
edited
Loading

Also:

  • lazy-pages-common -> lazy-pages/interface
  • core-backend/common/lazy_pages.rs -> lazy-pages/common
  • core_backend_common::LimitedStr -> core::LimitedStr

@ark0f ark0f added D1-core Gear Core A5-dontmerge PR should not be merged yet labels Sep 11, 2023
@gshep gshep mentioned this pull request Sep 12, 2023
Closed
Base automatically changed from al-non-lazy-removal to master September 18, 2023 18:16
ark0f added 26 commits September 18, 2023 21:31
@ark0f
Move state.rs into sandbox backend
6ab7136
@ark0f
Move funcs.rs into sandbox backend
a70b56c
@ark0f
Remove backend_common::Runtime
3a4453c
@ark0f
Move syscall_trace to funcs.rs
64b298c
@ark0f
Inline BackendState
5edfec5
@ark0f
Inline BackendTermination
11cc05b
@ark0f
Inline Environment
66b0a25
@ark0f
Move EnvironmentError into sandbox backend
e926946
@ark0f
Move ExtInfo into core-processor
9b762ce
@ark0f
Move SystemReservationContext into core-processor
eab6671
@ark0f
Move BackendReport into sandbox backend
7f23ea5
@ark0f
Remove MemoryAccessRecorder
001d5b6
@ark0f
Remove MemoryOwner
d6c7451
@ark0f
Move memory.rs into sandbox backend
1c2239b
@ark0f
Move errors into sandbox backend
e1baf55
@ark0f
Fix no_std
d265400
@ark0f
Move PTR_SPECIAL into sandbox backend
6e9cbbf
@ark0f
Rename gear-lazy-pages-common to gear-lazy-pages-interface
6121bd6
@ark0f
Introduce gear-lazy-pages-common
4a9908c
@ark0f
Move LimitedStr into core
4515f93
@ark0f
Remove gear-backend-common
8ae4609
@ark0f
Move sandbox backend into core-backend root
79bba62
@ark0f
Remove Sandbox prefixes from types in backend
45dd1b5
@ark0f
Fix benches and tests
11e238a
@ark0f
Fix Cargo.lock
ea0220b
@ark0f
Fix after-rebase mess
c140b7b
@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team and removed A5-dontmerge PR should not be merged yet labels Sep 19, 2023
@ark0f ark0f mentioned this pull request Sep 22, 2023
Merged
breathx
breathx approved these changes Sep 24, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
core-backend/Cargo.toml Outdated Show resolved Hide resolved
core-backend/src/env.rs Show resolved Hide resolved
core-backend/src/lib.rs Outdated Show resolved Hide resolved
core-backend/src/memory.rs Outdated Show resolved Hide resolved
core-backend/src/runtime.rs Show resolved Hide resolved
lazy-pages/common/Cargo.toml Outdated Show resolved Hide resolved
lazy-pages/common/Cargo.toml Show resolved Hide resolved
lazy-pages/interface/Cargo.toml Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
gshep
gshep approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

core/src/str.rs Outdated Show resolved Hide resolved
ark0f and others added 2 commits September 26, 2023 15:10
@ark0f
Merge remote-tracking branch 'origin/master' into al-backend-post-rem…
0f5e8ce 
…oval-refactoring

# Conflicts:
#	core-backend/src/funcs.rs
@ark0f @gshep
Update core/src/str.rs
15d64e5 
Co-authored-by: Georgy Shepelev <[email protected]>
@ark0f ark0f merged commit 54f23c0 into master Sep 26, 2023
10 checks passed
@ark0f ark0f deleted the al-backend-post-removal-refactoring branch September 26, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@grishasobol grishasobol grishasobol approved these changes

@gshep gshep gshep approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ark0f @gshep @grishasobol @breathx