Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples): make demos be more consistent #3138

Merged
merged 9 commits into from
Sep 19, 2023
Merged

refactor(examples): make demos be more consistent #3138

merged 9 commits into from
Sep 19, 2023

Conversation

shamilsan
Copy link
Contributor

@shamilsan shamilsan commented Aug 22, 2023 •
edited
Loading

  • Removed unused things.
  • Made manifest style united.
  • Split contract source files into lib.rs + wasm.rs.

@gear-tech/dev

@shamilsan shamilsan added the A0-pleasereview PR is ready to be reviewed by the team label Aug 22, 2023
@StackOverflowExcept1on
Copy link
Member

Can we consider removing parity-scale-codec and replacing with gstd re-export?

@shamilsan
Copy link
Contributor Author

Can we consider removing parity-scale-codec and replacing with gstd re-export?

I don't find importing parity-scale-codec too bad.

clearloop
clearloop approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@clearloop clearloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally can remove workspace = "../../" lol

breathx
breathx requested changes Aug 22, 2023
View reviewed changes
examples/async-init/Cargo.toml Show resolved Hide resolved
examples/fungible-token/io/Cargo.toml Outdated Show resolved Hide resolved
@shamilsan shamilsan added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A0-pleasereview PR is ready to be reviewed by the team labels Aug 22, 2023
@shamilsan shamilsan force-pushed the sy-cleanup-examples branch from 8ab704a to a632116 Compare August 22, 2023 12:58
@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Aug 23, 2023
@shamilsan shamilsan requested a review from breathx August 23, 2023 08:53
@shamilsan shamilsan changed the title chore: clean up example manifests chore: refactor examples to be more consistent Aug 23, 2023
@shamilsan
Copy link
Contributor Author

@breathx Please re-review

@shamilsan shamilsan changed the title chore: refactor examples to be more consistent refactor(examples): make demos be more consistent Aug 24, 2023
breathx
breathx approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw you can significantly reduce diff by initially just raneming previous lib.rs into wasm.rs and moving crate-related stuff into lib.rs (it will be the only diff just to keep history of demo authors etc)

examples/compose/src/wasm.rs Outdated Show resolved Hide resolved
examples/gas-burned/src/wasm.rs Show resolved Hide resolved
@shamilsan shamilsan merged commit f15ba78 into master Sep 19, 2023
8 checks passed
@shamilsan shamilsan deleted the sy-cleanup-examples branch September 19, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clearloop clearloop clearloop approved these changes

@breathx breathx breathx approved these changes

Assignees

@shamilsan shamilsan

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shamilsan @StackOverflowExcept1on @clearloop @breathx