Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request Commited [For adding Hover Effect] #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change Request Commited [For adding Hover Effect] #26

wants to merge 2 commits into from

Conversation

Prakarsh-Kaushik
Copy link

Issue #5

Things I Did

  • Added meme-img class to all meme images in index.html
    *Added hover effect too .meme-img class
  • Added smooth transition as requested in previous PR review @meinhoonharsh

DEMO

12.10.2021_18.06.08_REC.mp4

Copy link
Member

@meinhoonharsh meinhoonharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a great job, But since we've added another hover effect and this PR is having some conflicts, It would be great, If you can resolve the conflict and Improve the current Hover Effect.
Till then, labelling it as hacktoberfest-accepted so hacktoberfest team can look for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants