Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hover Effect to all Images #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Hover Effect to all Images #13

wants to merge 3 commits into from

Conversation

Prakarsh-Kaushik
Copy link

Issue #5

Things I Did

  • Added meme-img class to all meme images in index.html
  • Added hover effect too .meme-img class

Before Changes

before.mp4

After Changes

after.mp4

Copy link
Member

@meinhoonharsh meinhoonharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Really great that you've attached Videos to demonstrate what you've did
But the hover Effects are really very quick and not good from a User perspective
.
It would be great If you can add any smooth Transition for it

PS: please fetch the origin again, because some PRs have been merged, It may lead to Merge Conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants