feat: add notification helpers #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bczech
reviewed
Oct 18, 2024
R/utils.R
Outdated
| checkmate::assert_flag(html) | ||
| checkmate::assert_flag(inline) | ||
| checkmate::assert_from(host_name, min.chars = 1) | ||
| checkmate::assert_character(attached_files) |
There was a problem hiding this comment.
These two lines should be wrapped into if, to allow for using def arg with NULL, i.e.
if (!is.null(attached_files)) {
checkmate::assert_character(attached_files)
checkmate::assert_file_exists(attached_files)
}
R/duplicates.R
Outdated
| qs::qsave(att_l, att_f) | ||
| m_to <- get_env_var("EMAIL_RECIPIENT") | ||
| stopifnot(nchar(m_to) > 0) | ||
| send_email(body = msg, to = m_to, from = from, attached_files = att_f) |
R/duplicates.R
Outdated
| if ("slack" %in% by) { | ||
| s_to <- get_env_var("EMAIL_SLACK_NOTIFICATION") | ||
| stopifnot(nchar(s_to) > 0) | ||
| send_email(body = msg, to = s_to, from = from) |
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
bczech
reviewed
Oct 18, 2024
R/duplicates.R
Outdated
| m_sbj <- "[gDR] Error - unexpected duplicates found" | ||
|
|
||
| if ("email" %in% by) { | ||
| att_l <- list(c(dup_dt = dup_dt, metadata)) |
There was a problem hiding this comment.
Is it intentional to create one-element list instead of list(dup_dt = dup_dt, metadata = metadata)
There was a problem hiding this comment.
Yes. Usually it will be a list with multiple elements because metadata usually will be a non-empty list.
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
Co-authored-by: Bartek <[email protected]>
bczech
approved these changes
Oct 18, 2024
gladkia
commented
Oct 18, 2024
j-smola
reviewed
Oct 22, 2024
R/duplicates.R
Outdated
| s_to <- get_env_var("EMAIL_SLACK_NOTIFICATION") | ||
| stopifnot(nchar(s_to) > 0) | ||
| send_email(body = msg, subject = m_sbj, to = s_to) | ||
| } |
j-smola
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://code.roche.com/gdr/gdrviz/-/merge_requests/149.