Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdr 2591 #134

Merged
merged 24 commits into from
Oct 9, 2024
Merged

Gdr 2591 #134

merged 24 commits into from
Oct 9, 2024

Conversation

gladkia
Copy link
Collaborator

@gladkia gladkia commented Oct 7, 2024

Description

refactor the logic for dealing with duplicates in assay data

What changed?

Related JIRA issue: GDR-2591

Why was it changed?

clean-up the current logic for dealing with duplicates, add additional helpers

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@gladkia gladkia requested review from darsoo and j-smola October 7, 2024 07:42
@gladkia gladkia requested a review from a team as a code owner October 7, 2024 07:42
_pkgdown.yml Show resolved Hide resolved
tests/testthat/test-duplicates.R Outdated Show resolved Hide resolved
tests/testthat/test-duplicates.R Outdated Show resolved Hide resolved
tests/testthat/test-duplicates.R Outdated Show resolved Hide resolved
tests/testthat/test-duplicates.R Show resolved Hide resolved
R/duplicates.R Outdated Show resolved Hide resolved
R/duplicates.R Outdated Show resolved Hide resolved
inst/settings.json Show resolved Hide resolved
tests/testthat/test-duplicates.R Show resolved Hide resolved
R/duplicates.R Show resolved Hide resolved
Copy link
Contributor

@darsoo darsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

R/duplicates.R Show resolved Hide resolved
R/duplicates.R Outdated Show resolved Hide resolved
Co-authored-by: j-smola <[email protected]>
R/duplicates.R Outdated Show resolved Hide resolved
tests/testthat/test-duplicates.R Outdated Show resolved Hide resolved
@gladkia gladkia merged commit ed34794 into main Oct 9, 2024
3 of 4 checks passed
@gladkia gladkia deleted the GDR-2591 branch October 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants