Gdr 2591 #133
Merged
Gdr 2591 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladkia
requested review from
marcin-kam and
j-smola
and removed request for
a team
bczech
approved these changes
Oct 3, 2024
marcin-kam
approved these changes
Oct 3, 2024
j-smola
approved these changes
Oct 3, 2024
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Fixed bug in average_biological_replicates
Related JIRA issue: GDR-2591
Why was it changed?
In the function
average_biological_replicatesthe 'fit_type' columns were not recognized properly in metrics data transformed withgDRutils::flatten. This resulted in some duplicates not being recognized properly (i.e. records differing only infit_type).Checklist for sustainable code base
Logistic checklist
Screenshots (optional)