-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gdr 2419 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladkia
requested review from
darsoo and
bczech
and removed request for
a team
February 26, 2024 11:51
darsoo
approved these changes
Feb 26, 2024
j-smola
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe rethink group for functions?
- IMO not all function in "Combination helpers" is used only for combination data.
- "Mappping" seems to be list of function supporting "Pipeline"
- "Utils" and "Preparing input" are both "Preparing input for pipline"? As also "Identifying keys", right?
- etc.
Please, consider also
- update or "gDRcore.Rmd" vignette - "Drug processing section" section where due to lack of empty line list of steps disappeared;
- update the gDRcore architecture diagram in READMA.md as it is no longer readable on the pkgdown site.
PS: And fot is the reasone for function from constant.R
file?
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
Co-authored-by: j-smola <[email protected]>
1st section
2nd section
|
j-smola
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve pkgdown site
What changed?
Logistic checklist
Screenshots (optional)