Full height -> Margin Bottom

Full height on a gridded card breaks the margin bottom on the card; set mb on the containing col to compensate.
gburton · Jul 4, 2020 · a2e7137 · a2e7137
1 parent 0c2b16d
commit a2e7137
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/includes/modules/content/index/templates/tpl_cm_i_card_products.php b/includes/modules/content/index/templates/tpl_cm_i_card_products.php
@@ -5,8 +5,8 @@
     <?php
     while ($card_products = tep_db_fetch_array($card_products_query)) {
       ?>
-      <div class="col">
-        <div class="card h-100 mb-2 is-product" data-is-special="<?php echo (int)$card_products['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($card_products['final_price'], tep_get_tax_rate($card_products['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$card_products['manufacturers_id']); ?>">
+      <div class="col mb-2">
+        <div class="card h-100 is-product" data-is-special="<?php echo (int)$card_products['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($card_products['final_price'], tep_get_tax_rate($card_products['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$card_products['manufacturers_id']); ?>">
           <a href="<?php echo tep_href_link('product_info.php', 'products_id=' . (int)$card_products['products_id']); ?>"><?php echo tep_image('images/' . $card_products['products_image'], htmlspecialchars($card_products['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, '', true, 'card-img-top'); ?></a>
           <div class="card-body">         
             <h5 class="card-title">

diff --git a/includes/modules/content/index_nested/templates/tpl_cm_in_card_products.php b/includes/modules/content/index_nested/templates/tpl_cm_in_card_products.php
@@ -5,8 +5,8 @@
     <?php
     while ($card_products = tep_db_fetch_array($card_products_query)) {
       ?>
-      <div class="col">
-        <div class="card h-100 mb-2 is-product" data-is-special="<?php echo (int)$card_products['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($card_products['final_price'], tep_get_tax_rate($card_products['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$card_products['manufacturers_id']); ?>">
+      <div class="col mb-2">
+        <div class="card h-100 is-product" data-is-special="<?php echo (int)$card_products['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($card_products['final_price'], tep_get_tax_rate($card_products['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$card_products['manufacturers_id']); ?>">
           <a href="<?php echo tep_href_link('product_info.php', 'products_id=' . (int)$card_products['products_id']); ?>"><?php echo tep_image('images/' . $card_products['products_image'], htmlspecialchars($card_products['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, '', true, 'card-img-top'); ?></a>
           <div class="card-body">         
             <h5 class="card-title">

diff --git a/includes/modules/content/product_info/templates/tpl_cm_pi_also_purchased.php b/includes/modules/content/product_info/templates/tpl_cm_pi_also_purchased.php
@@ -5,8 +5,8 @@
     <?php
     while ($orders = tep_db_fetch_array($orders_query)) {      
       ?>
-      <div class="col">
-        <div class="card h-100 mb-2 is-product" data-is-special="<?php echo (int)$orders['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($orders['final_price'], tep_get_tax_rate($orders['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$orders['manufacturers_id']); ?>">
+      <div class="col mb-2">
+        <div class="card h-100 is-product" data-is-special="<?php echo (int)$orders['is_special']; ?>" data-product-price="<?php echo $currencies->display_raw($orders['final_price'], tep_get_tax_rate($orders['products_tax_class_id'])); ?>" data-product-manufacturer="<?php echo max(0, (int)$orders['manufacturers_id']); ?>">
           <a href="<?php echo tep_href_link('product_info.php', 'products_id=' . (int)$orders['products_id']); ?>"><?php echo tep_image('images/' . $orders['products_image'], htmlspecialchars($orders['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, '', true, 'card-img-top'); ?></a>
           <div class="card-body">         
             <h5 class="card-title">

diff --git a/templates/default/includes/components/product_listing.php b/templates/default/includes/components/product_listing.php
@@ -95,8 +95,8 @@
   $prod_list_contents = NULL;
 
   while ($listing = tep_db_fetch_array($listing_query)) {
-    $prod_list_contents .= '<div class="col">';
-      $prod_list_contents .= '<div class="card h-100 mb-2 is-product" data-is-special="' . (int)$listing['is_special'] . '" data-product-price="' . $currencies->display_raw($listing['final_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '" data-product-manufacturer="' . max(0, (int)$listing['manufacturers_id']) . '">' . PHP_EOL;
+    $prod_list_contents .= '<div class="col mb-2">';
+      $prod_list_contents .= '<div class="card h-100 is-product" data-is-special="' . (int)$listing['is_special'] . '" data-product-price="' . $currencies->display_raw($listing['final_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '" data-product-manufacturer="' . max(0, (int)$listing['manufacturers_id']) . '">' . PHP_EOL;
         if (isset($_GET['manufacturers_id'])  && tep_not_null($_GET['manufacturers_id'])) {
           $prod_list_contents .= '<a href="' . tep_href_link('product_info.php', 'manufacturers_id=' . (int)$_GET['manufacturers_id'] . '&products_id=' . (int)$listing['products_id']) . '">' . tep_image('images/' . $listing['products_image'], htmlspecialchars($listing['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, '', true, 'card-img-top') . '</a>' . PHP_EOL;
         } else {