Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ineffectual check #518

Merged
merged 1 commit into from
Oct 23, 2024
Merged

remove ineffectual check #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions core/vm/gas_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/math"
"github.com/ethereum/go-ethereum/log"

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / lint 

"github.com/ethereum/go-ethereum/log" imported and not used) (typecheck)

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / lint 

"github.com/ethereum/go-ethereum/log" imported and not used) (typecheck)

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / lint 

"github.com/ethereum/go-ethereum/log" imported and not used) (typecheck)

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / setup 

"github.com/ethereum/go-ethereum/log" imported and not used

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / conversion 

"github.com/ethereum/go-ethereum/log" imported and not used

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / setup 

"github.com/ethereum/go-ethereum/log" imported and not used

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / build 

"github.com/ethereum/go-ethereum/log" imported and not used

Check failure on line 24 in core/vm/gas_table.go

View workflow job for this annotation

GitHub Actions / test-process-verkle 

"github.com/ethereum/go-ethereum/log" imported and not used
"github.com/ethereum/go-ethereum/params"
)

Expand Down Expand Up @@ -499,12 +499,6 @@
}
}

if evm.chainRules.IsVerkle {
// TODO turn this into a panic (when we are sure this method
// will never execute when verkle is enabled)
log.Warn("verkle witness accumulation not supported for selfdestruct")
}

if !evm.StateDB.HasSelfDestructed(contract.Address()) {
evm.StateDB.AddRefund(params.SelfdestructRefundGas)
}
Expand Down
Loading