charge proper warm costs #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Sep 13, 2024
| return gas, nil | ||
| } | ||
| wgas := evm.Accesses.TouchBasicData(addr[:], false) | ||
| if wgas == 0 { | ||
| wgas = params.WarmStorageReadCostEIP2929 | ||
| } | ||
| var overflow bool | ||
| // We charge (cold-warm), since 'warm' is already charged as constantGas |
There was a problem hiding this comment.
yeah that's incorrect. There was a time when it was, but this comment should have been deleted a long time ago.
gballet
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes reg charging at least warm costs for precompile (2929). This was found by @tanishqjasoria by running the fixtures.