verify block witness and proof #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Ballet <[email protected]>
gballet
commented
Sep 13, 2024
core/block_validator.go
Outdated
| // Verify the proof | ||
| trie.DeserializeAndVerifyVerkleProof(block.ExecutionWitness().VerkleProof, parent.Root.Bytes(), block.Root().Bytes(), block.ExecutionWitness().StateDiff) | ||
|
|
||
| } // Verify that the advertised root is correct before |
There was a problem hiding this comment.
Suggested change
| } // Verify that the advertised root is correct before | |
| } | |
| // Verify that the advertised root is correct before |
gballet
commented
Sep 13, 2024
Comment on lines
+158
to
+162
| // Open the pre-tree to prove the pre-state against | ||
| parent := v.bc.GetHeaderByNumber(header.Number.Uint64() - 1) | ||
| if parent == nil { | ||
| return fmt.Errorf("nil parent header for block %d", header.Number) | ||
| } |
There was a problem hiding this comment.
The parent has most definitely already been loaded before, see if it's possible to pass it as a parameter.
gballet
commented
Sep 13, 2024
core/block_validator.go
Outdated
Comment on lines
138
to
156
| keys := statedb.Witness().Keys() | ||
| var key [32]byte | ||
| for _, stemdiff := range block.ExecutionWitness().StateDiff { | ||
| copy(key[:31], stemdiff.Stem[:]) | ||
| for _, suffixdiff := range stemdiff.SuffixDiffs { | ||
| key[31] = suffixdiff.Suffix | ||
|
|
||
| var found bool | ||
| for _, k := range keys { | ||
| if bytes.Equal(k, key[:]) { | ||
| found = true | ||
| break | ||
| } | ||
| } | ||
| if !found { | ||
| return fmt.Errorf("superfluous key %x could not be found in witness", key) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm only checking that the leaves from the block witness are present in the destination witness, because we are targeting state bloat. It could be that the witness does not contain all necessary leaves for stateless execution. This should be checked as well, either by execution (slow) or by just checking that there is the exact same amount of leaves.
Signed-off-by: Guillaume Ballet <[email protected]>
|
Nothing to salvage, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the conclusions from the geth retreat: the contents of proof and witness should be validated, in order to avoid bloating.