Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consume stable fixtures #478

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Aug 27, 2024

This PR adds a separate workflow to consume stable fixtures pulled from a defined tag in execution-spec-tests.

Depending on the PR, we should make an "expert call" if the fix in the PR should pass or not those stable fixtures, for example:

  • If the PR fixes a bug that affects filling, then it might make sense that the job shouldn't pass and that the PR should be merged anyway. This might be a signal to ask for a new execution-spec-tests release after the PR is merged.
  • If the PR shouldn't affect filling, then this job failing means we might have a regression, and the PR should be further inspected.

jsign added 2 commits August 27, 2024 11:10
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign force-pushed the jsign/ci-stable-fixtures branch from 732551b to 876439d Compare August 27, 2024 14:12
workflow_dispatch:

env:
FIXTURES_TAG: "[email protected]"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the corresponding tag in the release we want to target.

@jsign jsign requested a review from gballet August 27, 2024 14:33
@jsign jsign marked this pull request as ready for review August 27, 2024 14:33
Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet merged commit 9a8672f into kaustinen-with-shapella Aug 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants