cleanups #477
Merged
cleanups #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Aug 26, 2024
| @@ -128,10 +128,6 @@ func (t *VerkleTrie) GetAccount(addr common.Address) (*types.StateAccount, error | |||
| return nil, nil | |||
| } | |||
|
|
|||
| if len(values[utils.BasicDataLeafKey]) > 0 { | |||
There was a problem hiding this comment.
Considering the code right above, this if can't be false (i.e !emptyAccount).
Another way to see it is looking at L144. For the balance we didn't do this check either.
gballet
reviewed
Aug 26, 2024
| @@ -131,11 +131,8 @@ func (aw *AccessWitness) TouchTxOriginAndComputeGas(originAddr []byte) uint64 { | |||
| } | |||
|
|
|||
| func (aw *AccessWitness) TouchTxExistingAndComputeGas(targetAddr []byte, sendsValue bool) uint64 { | |||
| aw.touchAddressAndChargeGas(targetAddr, zeroTreeIndex, utils.BasicDataLeafKey, false) | |||
There was a problem hiding this comment.
actually I'm thinking we should set it to true because this isn't charged, it's just covered by the 21000 gas you pay for the tx.
There was a problem hiding this comment.
ah nvm, it was specified as such.
gballet
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.