add verkle support to evm t8n for test framework #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
t8n-verkle-exec-rebased
branch
from
95eb3c9 to
e23e237
Compare
jsign
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM, some things I'd have to look in more detail to be entirely convinced since I'm not used to how this tool is usually called from the testing infra -- but at some point we'll figure out soon if there's a problem.
Left some comments for your consideration.
core/state/database.go
Outdated
| @@ -415,7 +400,7 @@ func (db *cachingDB) OpenStorageTrie(stateRoot common.Hash, address common.Addre | |||
| } | |||
| } | |||
| if db.InTransition() { | |||
| fmt.Printf("OpenStorageTrie during transition, state root=%x root=%x\n", stateRoot, root) | |||
| // fmt.Printf("OpenStorageTrie during transition, state root=%x root=%x\n", stateRoot, root) | |||
| err := vkt.UpdateAccount(addr, account) | ||
| if err != nil { | ||
| return fmt.Errorf("error inserting account: %w", err) | ||
| } |
There was a problem hiding this comment.
Is the code missing chunkifying acc.Code and inserting that?
chunks := trie.ChunkifyCode(acc.Code)
vk.UpdateContractCode(...)
There was a problem hiding this comment.
yup, but let's see if this is still in use first
* t8n: add verkle-code-chunk-key cmd Signed-off-by: Ignacio Hagopian <[email protected]> * t8n: add verkle-chunkify-code cmd Signed-off-by: Ignacio Hagopian <[email protected]> * t8n: create separate verkle parent command Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
|
For PR readers, extra commands where added via #435 |
This was referenced May 9, 2024
* fix: add the storage processed flag to t8n. * chore: cancun -> prague typo.
gballet
force-pushed
the
t8n-verkle-exec-rebased
branch
from
d5e3191 to
122366d
Compare
gballet
commented
Jun 28, 2024
| @@ -1772,7 +1772,7 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error) | |||
| // If the verkle activation time hasn't started, declare it as "not started". | |||
| // This is so that if the miner activates the conversion, the insertion happens | |||
| // in the correct mode. | |||
| bc.stateCache.InitTransitionStatus(false, false) | |||
| bc.stateCache.InitTransitionStatus(false, false, common.Hash{}) | |||
There was a problem hiding this comment.
note to self: this is probably what kills the shadowfork
gballet
commented
Jun 28, 2024
Comment on lines
-82
to
-87
| parent := p.bc.GetBlockByHash(block.ParentHash()) | ||
| if !p.config.IsPrague(parent.Number(), parent.Time()) { | ||
| InsertBlockHashHistoryAtEip2935Fork(statedb, block.NumberU64()-1, block.ParentHash(), p.bc) | ||
| } else { | ||
| ProcessParentBlockHash(statedb, block.NumberU64()-1, block.ParentHash()) | ||
| } |
There was a problem hiding this comment.
this was one of the issues: worker.go also need to be updated not to insert the 256 blocks
|
This PR is good for merging, but before we can do that, we need to:
|
gballet
changed the title
jsign
reviewed
Jul 26, 2024
Merged
|
Rebased in another PR, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #406
TODO
kaustinen-with-shapellaNot part of this PR: enable verkle for blocktests