Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post-verge sync #404

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix post-verge sync #404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db0034
fix post-verge sync
gballet Mar 13, 2024
a6d9d38
review: fix truncated comment
gballet Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,10 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error)
if !bc.stateCache.InTransition() && !bc.stateCache.Transitioned() {
bc.stateCache.StartVerkleTransition(parent.Root, emptyVerkleRoot, bc.Config(), bc.Config().PragueTime, parent.Root)
}
} else {
// If the verkle activation time hasn't started, declare it as "not started".
// This is so that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case: this comment is truncated.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yeah

bc.stateCache.InitTransitionStatus(false, false)
Copy link
Collaborator

@jsign jsign Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the correct place to change this be here? https://github.com/gballet/go-ethereum/blob/transition-post-genesis/core/blockchain.go#L323-L331

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well for one thing the comment above is outdated.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR no it doesn't. The reason for this is that this activation comes from the miner, AFTER the blockchain has been initialized. It's also true of a reorg: if for whatever reason the verkle fork time changes (let's say it's pushed back) the reorg will have to go through without the chain to be reinitialized, and so NewBlockchain will not be called.

}
if parent.Number.Uint64() == conversionBlock {
bc.StartVerkleTransition(parent.Root, emptyVerkleRoot, bc.Config(), &parent.Time, parent.Root)
Expand Down
Loading