Rebased replay #391
Closed
Rebased replay #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Feb 27, 2024
Comment on lines
+372
to
+376
|
|
||
| if !beacon.IsPoSHeader(header) { | ||
| beacon.ethone.Finalize(chain, header, state, txs, uncles, nil) | ||
| return | ||
| } |
There was a problem hiding this comment.
Moved this so the conversion can happen for the block verifier.
The widrawals iteration should be fine since will be empty for the replay.
core/state/statedb.go
Outdated
Comment on lines
1351
to
1364
| LastCommittedRoot = root | ||
| return root, nil | ||
| } | ||
|
|
||
| var LastCommittedRoot common.Hash | ||
|
|
There was a problem hiding this comment.
Hacky way for the statedb fix.
gballet
force-pushed
the
transition-post-genesis
branch
from
31f522b to
009d3e2
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
force-pushed
the
transition-post-genesis
branch
from
ec5b79e to
bb3a39d
Compare
jsign
changed the base branch from
transition-post-genesis
to
jsign-transition-post-genesis-frozen
|
Superseded by #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.