eip2935 redesign: insert all 256 ancestors upon transition #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Feb 5, 2024
| @@ -184,6 +184,7 @@ func (pre *Prestate) Apply(vmConfig vm.Config, chainConfig *params.ChainConfig, | |||
| misc.ApplyDAOHardFork(statedb) | |||
| } | |||
| if chainConfig.IsPrague(big.NewInt(int64(pre.Env.Number)), pre.Env.Timestamp) { | |||
| // XXX figure out what to do for older hashes? | |||
There was a problem hiding this comment.
note to self: figure out what to do in this case.
jsign
reviewed
Feb 5, 2024
core/state_processor.go
Outdated
| @@ -87,7 +87,12 @@ func (p *StateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg | |||
| signer = types.MakeSigner(p.config, header.Number, header.Time) | |||
| ) | |||
| if p.config.IsPrague(block.Number(), block.Time()) { | |||
| ProcessParentBlockHash(statedb, block.NumberU64()-1, block.ParentHash()) | |||
| parent := p.bc.GetBlockByHash(block.ParentHash()) | |||
| if p.config.IsPrague(parent.Number(), parent.Time()) { | |||
core/state_processor.go
Outdated
| ancestor := chain.GetHeader(prevHash, prevNumber) | ||
| for i := prevNumber; i > 0 && i >= prevNumber-256; i-- { | ||
| ProcessParentBlockHash(statedb, i, ancestor.Hash()) | ||
| ancestor = chain.GetHeader(ancestor.ParentHash, ancestor.Number.Uint64()) |
There was a problem hiding this comment.
Shouldn't say: ancestor = chain.GetHeader(ancestor.ParentHash, ancestor.Number.Uint64()-1)?
Or also ancestor = chain.GetHeader(ancestor.ParentHash, i-1)
gballet
added a commit
that referenced
this pull request
May 7, 2024
* eip2935 redesign: only read target block hash * review fixes * fix: t8n tool
gballet
added a commit
that referenced
this pull request
May 8, 2024
* eip2935 redesign: only read target block hash * review fixes * fix: t8n tool
gballet
added a commit
that referenced
this pull request
May 8, 2024
* eip2935 redesign: only read target block hash * review fixes * fix: t8n tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of eip 2935 after it was suggested to simply insert all block hash values at fork time, instead of reading the 256th ancestor and using a complex fallback mechanism.