fix: support eip2935 blockhash within 256 blocks of genesis #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Feb 5, 2024
| // For testnets that start with eip2935 activated at genesis time, | ||
| // activate this code at block 1. | ||
| if evm.chainRules.IsPrague { | ||
| if getBlockHashFromContract(max(bnum, 256)-256, evm.StateDB, evm.Accesses) != (common.Hash{}) { |
There was a problem hiding this comment.
instead of reading the block hash at a "wrap around" negative number, it is now assumed that if eip2935 was activated at genesis time, then we can read from the contract no matter how many blocks away from the genesis we are.
There was a problem hiding this comment.
this is a bit weird, but it's just meant to be the same thing as max(block.number-256, 0)
There was a problem hiding this comment.
IMHO, I'd prefer to change this to max(block.number-256,0) in the code, to not have to mentally deal with this difference comparing with the EIP.
|
We're changing the eip again. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was the issue that the old behavior described in the EIP would not work for testnets that activate eip 2935 at genesis, which meant that stateless clients would not be able to execute a
BLOCKHASHinstruction within 256 blocks of genesis.I have pushed an update to this EIP and now this PR updates the code to this spec. This should actually not change the old behavior, only now it's semi-official.