Add eip2935 256th ancestor stem to witness #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
approved these changes
Jan 31, 2024
Comment on lines
+371
to
+372
| index, suffix := utils.GetTreeKeyStorageSlotTreeIndexes(key[:]) | ||
| statedb.Witness().TouchAddressOnWriteAndComputeGas(params.HistoryStorageAddress[:], *index, suffix) |
There was a problem hiding this comment.
Makes sense. At some point I wonder if it would be better to tie access witness recording with statedb methods that read/write the state.
It's just an idea, so this kind of miss are avoided.
There was a problem hiding this comment.
yeah it's something I've wanted to do for a long time. I tried once in the past but it was buggy and I had other priorities. I would wait for the shadowfork + rebase to do that, but it would be a pretty good thing.
gballet
commented
Feb 2, 2024
gballet
added a commit
that referenced
this pull request
May 7, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this stem is necessary for the stateless execution to be able to determine if the block height is at least 256 blocks past the fork block, and therefore if it needs to activate.