Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable chain replay #339

Closed
wants to merge 21 commits into from
Closed

Enable chain replay #339

wants to merge 21 commits into from

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Jan 23, 2024 •
edited
Loading

The suggested command to run the replay:

go run ./cmd/geth --datadir=.ethereum --nocompaction --cache.noprefetch=true --override.prague=1512818169 --override.overlay-stride=10000 --clear.verkle.costs=true import blocks_230k_14M500k

Remember to change the datadir and filenames to your corresponding context.

gballet added 14 commits November 8, 2023 10:51
@gballet
post-genesis transition
c6f2698
@gballet
quell linter issue
581d77d
@gballet
"unforce" verkle at genesis
94cf1bb
@gballet
support Transition post tree in conversion
21cebf0
@gballet
Refactor transition post genesis (#311)
1d80ebd 
* rewrite per-block conversion pointer management

* remove unused method

* fix: a branch that can verge at genesis or post genesis (#314)

* fix: import cycle in conversion refactor (#315)

* fix shadowfork panic in OpenStorageTrie
@gballet
fix: return error if witness costs OOG in instructions (#318)
532a370
@gballet
fix OpenStorageTrie: return an error instead of panicking if the acco…
48c6e62 
…unt tree not a verkle tree (#321)
@gballet
add a switch to force proof in blocks (#322)
dcb0a92 
* add a switch to force proof in blocks

* activate switch

* fix switch type
@gballet
add switch to override the stride of the overlay conversion (#323)
e842fd4 
* add switch to override the stride of the overlay conversion

* set a default stride of 10k
@gballet
add a few traces for relaunch
bdd68f5
@gballet
add missing step in the chain of setting the override for overlay stride
2c5d36c
@gballet
fix: save and load transition state for block processing (#324)
1e2d2ad 
* fix: save and load transition state for block processing

* log whether the tree is verkle in LoadTransitionState

* fix: ensure the transition is marked as started in insertChain

* dump saved address

* fix nil pointer panic

* remove stacktrace that is no longer useful

* fix a panic

* fix build

* check: copy current account address BEFORE it's saved

* mandatory panic fix

* Remove debug fmt.Println

* more cleanup + comments
@gballet
fix: ensure StorageProcessed is properly recovered
f68cc4e
@gballet
add traces for gas pool overflow
3c84e23
@jsign jsign force-pushed the jsign-fix-replay branch 2 times, most recently from 2a1838e to 4044d75 Compare January 23, 2024 22:07
jsign
jsign commented Jan 23, 2024
View reviewed changes
cmd/utils/cmd.go Show resolved Hide resolved
cmd/utils/flags.go Show resolved Hide resolved
core/block_validator.go Show resolved Hide resolved
cmd/geth/conversion.txt Outdated Show resolved Hide resolved
core/state_processor.go Outdated Show resolved Hide resolved
core/vm/interpreter.go Outdated Show resolved Hide resolved
params/config.go Outdated Show resolved Hide resolved
@jsign jsign closed this Jan 26, 2024
@jsign jsign reopened this Jan 26, 2024
@gballet gballet force-pushed the verkle-costs-activation-switch branch from 49ca31a to b2381d3 Compare January 26, 2024 16:57
gballet and others added 5 commits January 26, 2024 17:57
@gballet @jsign
cmd/{geth, utils}: add a command to clear verkle costs (#326)
95ab716 
* cmd/{geth, utils}: add a command to clear verkle costs

fix:  boolean issue

fix: load finalization state in FinalizeAndAssemble (#340)

* Conversion and TransitionTrie fixes (#346)

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* remove old comment

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>

* trace cleanup

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
@jsign
replay changes
9813f39 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign
use timesetamp for forking and simplify api
0db0f60 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign
fix typos
7b2e9c0 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign
rebase fix
9fab31f 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign changed the base branch from verkle-costs-activation-switch to transition-post-genesis January 26, 2024 17:08
@jsign jsign changed the title Replay enabling changes Enable chain replay Jan 26, 2024
@jsign
params: fix fork ordering
9fadea9 
Signed-off-by: Ignacio Hagopian <[email protected]>
@gballet gballet force-pushed the transition-post-genesis branch from 04b0304 to 67335d5 Compare February 22, 2024 14:20
@gballet gballet force-pushed the transition-post-genesis branch from 67335d5 to 4adff4b Compare February 22, 2024 15:05
@gballet gballet mentioned this pull request Feb 22, 2024
Closed
@jsign
Resumable replays & fix precompile fork ordering (#373)
cdda01c 
* fix precompiles configuration for replay Prague

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes for resumable replay after conversion

Signed-off-by: Ignacio Hagopian <[email protected]>

* extra fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* remove blank line

Signed-off-by: Ignacio Hagopian <[email protected]>

* fix underflow bug

Signed-off-by: Ignacio Hagopian <[email protected]>

* fix fork ordering for constantinople

Signed-off-by: Ignacio Hagopian <[email protected]>

* fix precompile switch order

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign changed the base branch from transition-post-genesis to scwallet-puk-count February 23, 2024 18:20
@jsign jsign changed the base branch from scwallet-puk-count to transition-post-genesis February 23, 2024 18:20
@gballet gballet force-pushed the transition-post-genesis branch from 31f522b to 009d3e2 Compare February 28, 2024 09:46
@gballet gballet force-pushed the transition-post-genesis branch from ec5b79e to bb3a39d Compare March 26, 2024 09:13
@jsign
Copy link
Collaborator Author

jsign commented May 6, 2024

Superseded by #431

@jsign jsign closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet left review comments

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsign @gballet