accesswitness: avoid charging cost for origin and target #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Jan 19, 2024
Comment on lines
-484
to
-485
| txCost1 := params.WitnessBranchWriteCost*2 + params.WitnessBranchReadCost*2 + params.WitnessChunkWriteCost*3 + params.WitnessChunkReadCost*10 + params.TxGas | ||
| txCost2 := params.WitnessBranchWriteCost + params.WitnessBranchReadCost*2 + params.WitnessChunkWriteCost*2 + params.WitnessChunkReadCost*10 + params.TxGas |
There was a problem hiding this comment.
Note that in both cases, now the cost is 21000 (i.e: params.TxGas).
There was a problem hiding this comment.
and that's exactly what I wanted 🎉
Comment on lines
-486
to
-487
| contractCreationCost := intrinsicContractCreationGas + uint64(6900 /* from */ +7700 /* creation */ +2939 /* execution costs */) | ||
| codeWithExtCodeCopyGas := intrinsicCodeWithExtCodeCopyGas + uint64(6900 /* from */ +7000 /* creation */ +315944 /* execution costs */) |
There was a problem hiding this comment.
Only the from part of the cost is removed, as expected. (Or at least, that's my interpretation on how things should work).
gballet
reviewed
Jan 19, 2024
Comment on lines
-484
to
-485
| txCost1 := params.WitnessBranchWriteCost*2 + params.WitnessBranchReadCost*2 + params.WitnessChunkWriteCost*3 + params.WitnessChunkReadCost*10 + params.TxGas | ||
| txCost2 := params.WitnessBranchWriteCost + params.WitnessBranchReadCost*2 + params.WitnessChunkWriteCost*2 + params.WitnessChunkReadCost*10 + params.TxGas |
There was a problem hiding this comment.
and that's exactly what I wanted 🎉
Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
* accesswitness: avoid charging cost for origin and target Signed-off-by: Ignacio Hagopian <[email protected]> * make the linter happy Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* accesswitness: avoid charging cost for origin and target Signed-off-by: Ignacio Hagopian <[email protected]> * make the linter happy Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* accesswitness: avoid charging cost for origin and target Signed-off-by: Ignacio Hagopian <[email protected]> * make the linter happy Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how we charge
fromandtoin the access witness.The goal is to have a minimal change that would keep the currently expected 21000 gas for simple transfers, such that we avoid breaking potentially many hardcoded rules in existing toolings.