fix: add proof of absence for chunks when contract creation reverts #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jan 16, 2024
| err = ErrOutOfGas | ||
| if evm.chainRules.IsPrague { | ||
| if err == nil || err == ErrExecutionReverted { | ||
| if !contract.UseGas(evm.Accesses.TouchAndChargeContractCreateCompleted(address.Bytes()[:])) { |
There was a problem hiding this comment.
actually in the context of a reverted execution, the values should be nil and not the destination values. Let's first confirm that this is indeed a bug that needs fixing, I'm not so sure anymore.
|
After thinking it through, it appears that this makes no sense: the contract isn't added to the state, since its creation reverted. So there wouldn't be any change to the tree, so no need to add it to the witness: the stateless client will not try to access the tree at this location either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding contract chunks to the witness only occurred when the creation transaction was a success.
The question that arises is: do we need to add the address to the witness, knowing that it's not created? At first, I thought that this was the case, but actually since the creation isn't executed, it should not be the case. This needs to be though through further.