add witness costs as tracer parameter #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't complete this one, the tracer has been completely rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With verkle, gas consumption extends beyond the naked cost of calling an operation: depending on what areas of memory get touched, there is a potential extra gas charged.
This PR is still in draft, because there are several tweaks that need to be considered: for one, extracting gas data from the witness implies to change the signature of the return function to also include the witness.
It might be easier to change the signature of
dynamicGasto accept thepcfrom the interpreter and just bulk the witness gas with the consumed gas. And we might combine both to report the witness gas while bulking both.