fix: support a verkle pre-tree at the conversion block #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jan 29, 2024
gballet
added a commit
that referenced
this pull request
May 7, 2024
* fix: support a verkle pre-tree at the conversion block * make linter happy
gballet
added a commit
that referenced
this pull request
May 8, 2024
* fix: support a verkle pre-tree at the conversion block * make linter happy
gballet
added a commit
that referenced
this pull request
May 8, 2024
* fix: support a verkle pre-tree at the conversion block * make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current conversion code panics if it tries to create a proof at the first block. This is because the previous tree is a MPT and no verkle proof can be made against the MPT.
As a result, this PR swaps the MPT with an empty verkle tree, so the proof will be against an empty verkle tree, which is the correct interpretation of a transition proof.