Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable header layering checks for bazel build #1505

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Conversation

shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented Nov 14, 2024

🦟 Bug fix

Summary

Enables process_headers_in_dependencies for Bazel build to flag missing dependencies earlier with parse_headers and layering_check which are already enabled.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll merged commit 0a36844 into sdf15 Nov 16, 2024
16 checks passed
@mjcarroll mjcarroll deleted the shameek/layering branch November 16, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants