Add //sensor/frame_id to SDF spec 1.12 #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
9 tasks
Signed-off-by: Ian Chen <[email protected]>
scpeters
reviewed
Jul 4, 2024
| @@ -296,6 +299,8 @@ void defineCamera(pybind11::object module) | |||
| .value("BAYER_BGGR8", sdf::PixelFormatType::BAYER_BGGR8) | |||
| .value("BAYER_GBRG8", sdf::PixelFormatType::BAYER_GBRG8) | |||
| .value("BAYER_GRBG8", sdf::PixelFormatType::BAYER_GRBG8); | |||
|
|
|||
| GZ_UTILS_WARN_RESUME__DEPRECATED_DECLARATION | |||
There was a problem hiding this comment.
do you mind adding the new APIs to pySensor.cc?
There was a problem hiding this comment.
ah yes added. d64d5f6
ahcorde
approved these changes
Jul 4, 2024
Signed-off-by: Ian Chen <[email protected]>
scpeters
approved these changes
Jul 8, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related issue: gazebosim/gz-sensors#306
Summary
There are many ways to specify the sensor frame id in gazebo, e.g.
//sensor/gz_frame_id- Parsed by gz-sensors. Not in official sdf spec//sensor/ignition_frame_id- Parsed by gz-sensors (removed in harmonic). Not in official sdf spec//sensor/camera/optical_frame_idThis PR proposes a
//sensor/frame_idsdf element to rule them all. Yes now it just adds one more way to do it but fear not, all others are being deprecated (ignition_frame_idis already gone)Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.